OR has precedence over AND

[frosas]

It happens that in DQL the logical operator OR has precedence over AND, which it neither behaves according to common sense nor the manual.

I'll use the Doctrine_Query_Condition unit test code as example. The WHERE condition:

(User.name LIKE 'z%') OR User.name LIKE 's%' AND User.name LIKE 'a%'

is expected to become:

(e.name LIKE 'z%' OR (e.name LIKE 's%' AND e.name LIKE 'a%'))

(note the brackets are opcional) but this is what we get:

((e.name LIKE 'z%' OR e.name LIKE 's%') AND e.name LIKE 'a%')

Attached is the patch that hopefully solves this.

[guilhermeblanco]

Hi...

Your ticket is almost right. It only fails in one point. I'll not consider the case that the query is wrong.
Currently, AND has precedence over OR. This is what the manual describes and indeed is what happens in Doctrine. That's what Doctrine does, CURRENTLY.

The fact is that OR should have precedence over AND (your wish), but as I told you, now OR accepts only one expression which means it'll always behave like I told you.
We can't fix that for 0.X or 1.X, but this change is already made in 2.X (which will be released next year). I did a simple check and applied your fix. It broke some tests and also broke a lot of code in 2 projects I tried.
So, I have to tell you we cannot fix it for 0.X, but we're studying the possibility to apply it in 1.X. It's fact that this change will be active in 2.X, so it'll reality in the future, I just don't know when.

I'm moving your ticket to 1.0, since we're considering this change there.

[jwage]

(In [4683]) fixes #939

[anonymous]

Milestone New deleted