Ticket #628 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

getParam: unused argument "value" and ignored "namespace"

Reported by: KingCrunch Owned by: zYne-
Priority: minor Milestone: 2.0.0 (OLD)
Component: Other Version:
Severity: Keywords:
Cc: Has Test:
Status: Has Patch:

Description

I dont know, if there is any ticket about this already. Im using Doctrine just for some days.

In Doctrine_Configurable:

public function getParam($name, $value, $namespace) 
    {
    	if ($namespace == null) {
    	    $namespace = $this->getAttribute(Doctrine::ATTR_DEFAULT_PARAM_NAMESPACE);
    	}
    	
        if ( ! isset($this->_params[$name])) {
            if (isset($this->parent)) {
                return $this->parent->getParam($name);
            }
            return null;
        }
        return $this->_params[$name];
    }

$namespace will be retrieved, but is not used for retrieving the param itself. Also the argument $value is never used and it seems not to be very useful to give a value to a getter-method. $namespace should also have a default-value like the corresponding setter-method setParam.

Change History

Changed 3 years ago by jwage

  • owner changed from somebody to zYne-
  • milestone set to 1.0

Changed 2 years ago by jwage

  • status changed from new to closed
  • resolution set to fixed

Changed 2 years ago by anonymous

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.