Ticket #1745 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

Bug in Behavior Searchable with accentued characters

Reported by: Garfield-fr Owned by: Jonathan.Wage
Priority: minor Milestone: Unknown
Component: Attributes Version: 1.0.4
Severity: Keywords: Searchable
Cc: Has Test: yes
Status: Pending Core Response Has Patch: yes

Description

I have tested with this string: 

Savièse

Result: In my table xxx_index, i have 2 records 

1: Savi
2: se

Attachments

analyser_standard_v10.patch (0.6 KB) - added by Garfield-fr 7 months ago.
Patch for version 1.0
analyser_standard_v11.patch (2.0 KB) - added by Garfield-fr 7 months ago.
Patch for version 1.1
analyser_standard_v10_v2.patch (0.5 KB) - added by Garfield-fr 7 months ago.
Patch for version 1.0 v2 with all tests ok
analyser_standard_v11_v2.patch (1.9 KB) - added by Garfield-fr 7 months ago.
Patch for version 1.1 v2 with all tests ok

Change History

Changed 7 months ago by Garfield-fr

  • has_test set

#5291 for version 1.0
#5292 for version 1.1

Changed 7 months ago by Garfield-fr

Patch for version 1.0

Changed 7 months ago by Garfield-fr

Patch for version 1.1

Changed 7 months ago by Garfield-fr

  • has_patch set

Changed 7 months ago by jwage

  • milestone changed from 1.0.5 to Unknown

These patches don't work well with the test suite. It adds notices and a few new fails. Can you check that?

Changed 7 months ago by Garfield-fr

Patch for version 1.0 v2 with all tests ok

Changed 7 months ago by Garfield-fr

Why are you deleted my testcase for version 1.1 ???

With accentued char, your function translit don't work. iconv with translit don't work correctly.

Changed 7 months ago by jwage

Because currently the test case fails and we don't have a fix for it yet. The patches you provide cause some errors. Once we have a patch that works we can commit it.

Changed 7 months ago by Garfield-fr

Patch for version 1.1 v2 with all tests ok

Changed 7 months ago by Garfield-fr 

LOG TEST VERSION 1.1

BEFORE:
Tested: 349 test cases.
Successes: 3886 passes.
Failures: 5 fails.
Number of new Failures: 0 
Number of fixed Failures: 0

AFTER:
Tested: 349 test cases.
Successes: 3888 passes.
Failures: 3 fails.
Number of new Failures: 0 
Number of fixed Failures: 1 Doctrine_Ticket_1745_TestCase

Changed 7 months ago by jwage

  • status changed from new to closed
  • resolution set to fixed

(In [5304]) [1.0, 1.1] Fixed issue with accented characters with Searchable behavior (closes #1745)

Note: See TracTickets for help on using tickets.