Ticket #1456 (closed defect: fixed)

Opened 10 months ago

Last modified 9 months ago

postDelete is run outside of the transaction on skipped events

Reported by: chorizo Owned by: jwage
Priority: minor Milestone: 1.0.3
Component: Attributes Version: 1.0.0
Severity: Keywords:
Cc: Has Test: no
Status: Pending Core Response Has Patch: no

Description

When you skipEvent() in preDelete(), the postDelete() is run outside of the internal transaction, whereas when you don't skip the event, it is run inside the transaction. It would be good if both were run inside the transaction so that you don't have to conditionally start a transaction in postDelete depending on if the event was skipped.

I think this is just a reordering of these lines:  http://trac.phpdoctrine.org/browser/branches/1.0/lib/Doctrine/Connection/UnitOfWork.php#L278

Change History

Changed 10 months ago by jwage

  • milestone set to 1.0.3

Changed 9 months ago by jwage

  • status changed from new to closed
  • resolution set to fixed

In r4988 this was fixed. Thanks for the report.

Note: See TracTickets for help on using tickets.