Ticket #1418 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

Missing identifier quoting in having query part

Reported by: mm Owned by: romanb
Priority: blocker Milestone: 1.0.1
Component: Query/Hydration Version: 0.11.0
Severity: Keywords: having, quoting, query, ATTR_QUOTE_IDENTIFIER
Cc: Has Test: no
Status: Pending Core Response Has Patch: no

Description

Similar behaviour to #1272 and #1262, missing identifier quoting in HAVING part. Probably affects 1.0 version because file has no changes, but I didn't test the 1.0 version.

Actual class Doctrine_Query_Having line: 76-77

    return $func;
    } else {
    return $func;

Patch

    return $this->query->getConnection()->quoteIdentifier($func);
    } else {
    return $this->query->getConnection()->quoteIdentifier($func);

Change History

Changed 10 months ago by anonymous

  • milestone New deleted

Milestone New deleted

Changed 10 months ago by romanb

  • milestone set to 1.0.1

Changed 10 months ago by jwage

  • status changed from new to closed
  • resolution set to fixed

(In [4888]) fixes #1418

Note: See TracTickets for help on using tickets.