Ticket #1266 (closed defect: fixed)

Opened 20 months ago

Last modified 19 months ago

Table Export with Mssql never produces a NULL column

Reported by: temp Owned by: jwage
Priority: major Milestone:
Component: Schema Files Version: 0.11.0
Severity: Keywords: mssql
Cc: Has Test: no
Status: Pending Core Response Has Patch: no

Description

Version 0.11.1

When exporting a table definition with mssql, a column that has no "notnull" attribute results in a table with NOT NULL. I had to change line 703 in getDeclaration() in Doctrine/Export.php to an explicit [...] ? ' NOT NULL' : ' NULL'; to allow null values.

Change History

  Changed 19 months ago by temp

  • milestone changed from Unknown to 1.0.0-RC1

  Changed 19 months ago by guilhermeblanco

  • status changed from new to closed
  • resolution set to fixed

(In [4779]) fixed #1266. Thanks for the information! Also I removed the comments I added previously in JoinConditionTestCase?.php

follow-up: ↓ 4   Changed 19 months ago by Markus.Staab

  • status changed from closed to reopened
  • resolution fixed deleted

you already fixed the typos in the variable names, but it is still wrong in the phpdocs..

in reply to: ↑ 3   Changed 19 months ago by guilhermeblanco

  • status changed from reopened to closed
  • resolution set to fixed

Replying to Markus.Staab:

you already fixed the typos in the variable names, but it is still wrong in the phpdocs..

phpdocs are generated on demand. I don't have enough karma to do that, but the ticket itself was fixed.

Please open another ticket and point to 1.0 Documentation if it's not generated automatically.

  Changed 19 months ago by Markus.Staab

I'm talking about the comments inside the sourcecode of method getNotNullFieldDeclaration(). see your changeset r4779

  Changed 19 months ago by anonymous

  • milestone New deleted

Milestone New deleted

Note: See TracTickets for help on using tickets.