Changeset 4696

Timestamp:

07/19/08 18:57:36 (5 months ago)

Author:

guilhermeblanco

Message:

Fixed #1222. Added new Record state called STATE_TLOCKED, which means the Record is transient (record is not yet persisted).

Location:

branches/0.11/lib/Doctrine

Files:

• Connection/UnitOfWork.php (modified) (2 diffs)
• Record.php (modified) (5 diffs)

branches/0.11/lib/Doctrine/Connection/UnitOfWork.php

@@ -52 +52 @@
 
         $state = $record->state();
-        if ($state === Doctrine_Record::STATE_LOCKED) {
+        if ($state === Doctrine_Record::STATE_LOCKED || $state === Doctrine_Record::STATE_TLOCKED) {
             return false;
         }
 
-        $record->state(Doctrine_Record::STATE_LOCKED);
+        $record->state($record->exists() ? Doctrine_Record::STATE_LOCKED : Doctrine_Record::STATE_TLOCKED);
 
         $conn->beginInternalTransaction();
@@ -97 +97 @@
         $state = $record->state();
 
-        $record->state(Doctrine_Record::STATE_LOCKED);
+        $record->state($record->exists() ? Doctrine_Record::STATE_LOCKED : Doctrine_Record::STATE_TLOCKED);
 
         foreach ($saveLater as $fk) {

branches/0.11/lib/Doctrine/Record.php

@@ -78 +78 @@
      */
     const STATE_LOCKED     = 6;
+    
+    /**
+     * TLOCKED STATE
+     * a Doctrine_Record is temporarily locked (and transient) during deletes and saves
+     *
+     * This state is used internally to ensure that circular deletes
+     * and saves will not cause infinite loops
+     */
+    const STATE_TLOCKED     = 7;
 
     /**
@@ -668 +677 @@
         $err = false;
         if (is_integer($state)) {
-            if ($state >= 1 && $state <= 6) {
+            if ($state >= 1 && $state <= 7) {
                 $this->_state = $state;
             } else {
@@ -1291 +1300 @@
     public function toArray($deep = true, $prefixKey = false)
     {
-        if ($this->_state == self::STATE_LOCKED) {
+        if ($this->_state == self::STATE_LOCKED || $this->_state == self::STATE_TLOCKED) {
             return false;
         }
         
         $stateBeforeLock = $this->_state;
-        $this->_state = self::STATE_LOCKED;
+        $this->_state = $this->exists() ? self::STATE_LOCKED : self::STATE_TLOCKED;
         
         $a = array();
@@ -1465 +1474 @@
     {
         return ($this->_state !== Doctrine_Record::STATE_TCLEAN &&
-                $this->_state !== Doctrine_Record::STATE_TDIRTY);
+                $this->_state !== Doctrine_Record::STATE_TDIRTY &&
+                $this->_state !== Doctrine_Record::STATE_TLOCKED);
     }
 
@@ -1925 +1935 @@
     public function free($deep = false)
     {
-        if ($this->_state != self::STATE_LOCKED) {
-            $this->_state = self::STATE_LOCKED;
+        if ($this->_state != self::STATE_LOCKED && $this->_state != self::STATE_TLOCKED) {
+            $this->_state = $this->exists() ? self::STATE_LOCKED : self::STATE_TLOCKED;
 
             $this->_table->getRepository()->evict($this->_oid);